Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new api gateway property names in aws-nodejs-typescript template #10214

Conversation

fredericbarthelet
Copy link
Contributor

Implement new http.request.schemas instead of http.request.schema as per https://github.com/serverless/serverless/blob/master/docs/deprecations.md#aws-api-gateway-schemas for aws-nodejs-typescript template

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #10214 (5892d85) into master (55146c4) will not change coverage.
The diff coverage is n/a.

❗ Current head 5892d85 differs from pull request most recent head 0e7e23c. Consider uploading reports for the commit 0e7e23c to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10214   +/-   ##
=======================================
  Coverage   85.38%   85.38%           
=======================================
  Files         339      339           
  Lines       13836    13836           
=======================================
  Hits        11814    11814           
  Misses       2022     2022           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55146c4...0e7e23c. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great call @fredericbarthelet !

@medikoo medikoo merged commit 6671d98 into serverless:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants