Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Fix npm v8 related issues, improve reliablity of Windows testing #10252

Merged
merged 4 commits into from Nov 17, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Nov 17, 2021

After switching integration testing on v3 branch to Node.js v16, package integration tests started to fail. It's due to npm v8 leaving more files behind.

Additionally, ensure the reliability of Windows tests. Discovered that some tests fail on my side, due to slightly different environmental characteristics.

@medikoo medikoo added the tests label Nov 17, 2021
@medikoo medikoo self-assigned this Nov 17, 2021
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #10252 (31845d1) into master (b8d3865) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10252   +/-   ##
=======================================
  Coverage   85.38%   85.39%           
=======================================
  Files         339      339           
  Lines       13838    13840    +2     
=======================================
+ Hits        11816    11819    +3     
+ Misses       2022     2021    -1     
Impacted Files Coverage Δ
lib/cli/triage.js 92.13% <0.00%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8d3865...31845d1. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@medikoo medikoo merged commit b41c6e4 into master Nov 17, 2021
@medikoo medikoo deleted the 1117-improve-tests-reliability branch November 17, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants