fix(AWS sqs): Ensure only ARN in plain string form is allowed as direct sqs event assignment

[sdas13]

Closes: #9723

[codecov]

Codecov Report

Merging #10263 (04cb05f) into master (ce66591) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10263      +/-   ##
==========================================
- Coverage   85.39%   85.39%   -0.01%     
==========================================
  Files         339      339              
  Lines       13840    13854      +14     
==========================================
+ Hits        11819    11830      +11     
- Misses       2021     2024       +3     

Impacted Files	Coverage Δ
lib/plugins/aws/package/compile/events/sqs.js	100.00% <ø> (ø)
lib/plugins/aws/deploy/lib/createStack.js	94.00% <0.00%> (-3.88%)	⬇️
lib/plugins/aws/lib/updateStack.js	94.80% <0.00%> (-3.81%)	⬇️
lib/plugins/aws/package/compile/events/s3/index.js	98.54% <0.00%> (ø)
lib/plugins/aws/provider.js	94.97% <0.00%> (+0.65%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce66591...04cb05f. Read the comment docs.

[medikoo]

@sdas13 thanks for contribution! Please mark PR as ready for review, once it's finalized.

[medikoo]

@sdas13 thanks for picking this up. Still proposed implementation doesn't reflect the agreed solution (as outlined here: #9723 (comment))

If for some reason you do not agree with that, best if you elaborate in the issue first

[sdas13]

Hey @medikoo
Thanks for the feedback. I will use awsArnString at the top level.

serverless/lib/plugins/aws/package/compile/events/sqs.js

Line 17 in 317cfe1

{ $ref: '#/definitions/awsArn' },

But in case of passing CF intrinsic functions directly to sqs input, there will be a configuration warning that should have required property 'arn' but the Type Error will be still there, since EventSourceArn will become undefined

serverless/lib/plugins/aws/package/compile/events/sqs.js

Line 62 in 317cfe1

if (EventSourceArn['Fn::GetAtt']) {

Should it be handled as well or we just fix the schema?

[medikoo]

But in case of passing CF intrinsic functions directly to sqs input, there will be a configuration warning that should have required property 'arn' but the Type Error will be still there, since EventSourceArn will become undefined

@sdas13 Can you provide an example of a configuration that will raise this problem? Sorry, from description it's not perfectly to me

[sdas13]

functions:
    eventHandler:
       handler: handler.test
       events:
          - sqs: !ImportValue MyExportedQueueArnId               

@medikoo this configuration would throw a Type Error

[medikoo]

@medikoo this configuration would throw a Type Error

And that's ok, as that'll become invalid by schema - solution is to update schema so only ARN in plain string form is allowed as direct sqs event assignment, and CF intrinsic functions are supported only in object configuration form (so when arn is defined as a property on object assigned to sqs)

[sdas13]

thanks @medikoo I will update the PR

[medikoo]

Thank you @sdas13 ! That looks great :)

[sdas13]

Thank you for your guidance @medikoo