Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AWS Kafka): Add support for mTLS access configuration #10273

Merged
merged 6 commits into from Dec 5, 2021

Conversation

mishabruml
Copy link
Contributor

Closes: #{10260}

#10260

@mishabruml mishabruml marked this pull request as ready for review November 24, 2021 23:34
@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #10273 (353e64b) into master (44511f3) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10273      +/-   ##
==========================================
+ Coverage   85.39%   85.42%   +0.03%     
==========================================
  Files         339      339              
  Lines       13842    13919      +77     
==========================================
+ Hits        11821    11891      +70     
- Misses       2021     2028       +7     
Impacted Files Coverage Δ
lib/plugins/aws/package/compile/events/kafka.js 98.61% <100.00%> (+0.30%) ⬆️
lib/plugins/aws/deploy/lib/createStack.js 94.00% <0.00%> (-3.88%) ⬇️
lib/plugins/aws/lib/updateStack.js 94.80% <0.00%> (-3.81%) ⬇️
lib/configuration/variables/resolve.js 97.72% <0.00%> (-0.87%) ⬇️
lib/plugins/aws/deployFunction.js 96.86% <0.00%> (-0.19%) ⬇️
lib/plugins/aws/package/compile/events/sqs.js 100.00% <0.00%> (ø)
lib/plugins/aws/utils/getS3EndpointForRegion.js 100.00% <0.00%> (ø)
lib/plugins/aws/package/compile/events/s3/index.js 98.54% <0.00%> (ø)
lib/plugins/aws/package/compile/events/stream.js 98.23% <0.00%> (+0.04%) ⬆️
lib/plugins/aws/provider.js 94.97% <0.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44511f3...353e64b. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mishabruml - thanks a lot, it looks great overall. I have a few minor suggestions, please let me know what do you think 🙇

lib/plugins/aws/package/compile/events/kafka.js Outdated Show resolved Hide resolved
lib/plugins/aws/package/compile/events/kafka.js Outdated Show resolved Hide resolved
docs/providers/aws/events/kafka.md Show resolved Hide resolved
docs/providers/aws/events/kafka.md Outdated Show resolved Hide resolved
docs/providers/aws/events/kafka.md Outdated Show resolved Hide resolved
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mishabruml - as for testing of schema, we don't usually do that and I don't think we should change that in this particular case - I would suggest to remove all INVALID_NON_SCHEMA_COMPLIANT_CONFIGURATION tests

lib/plugins/aws/package/compile/events/kafka.js Outdated Show resolved Hide resolved
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mishabruml, well done 👏 I only have few minor remarks and we're good to ship it 🚀

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mishabruml, well done 👍

@pgrzesik pgrzesik changed the title feat(AWS Lambda) mTLS kafka event source feat(AWS Kafka): Add support for mTLS access configuration Dec 5, 2021
@pgrzesik pgrzesik merged commit 9faf37a into serverless:master Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants