New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AWS Kafka): Add support for mTLS
access configuration
#10273
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10273 +/- ##
==========================================
+ Coverage 85.39% 85.42% +0.03%
==========================================
Files 339 339
Lines 13842 13919 +77
==========================================
+ Hits 11821 11891 +70
- Misses 2021 2028 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @mishabruml - thanks a lot, it looks great overall. I have a few minor suggestions, please let me know what do you think 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @mishabruml - as for testing of schema, we don't usually do that and I don't think we should change that in this particular case - I would suggest to remove all INVALID_NON_SCHEMA_COMPLIANT_CONFIGURATION
tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @mishabruml, well done 👏 I only have few minor remarks and we're good to ship it 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mishabruml, well done 👍
mTLS
access configuration
Closes: #{10260}
#10260