Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add event filtering patterns to stream event type #10285

Merged
merged 8 commits into from Nov 30, 2021
Merged

Add event filtering patterns to stream event type #10285

merged 8 commits into from Nov 30, 2021

Conversation

fredericbarthelet
Copy link
Contributor

Addresses: #10284

@fredericbarthelet fredericbarthelet marked this pull request as draft November 28, 2021 19:58
@codecov
Copy link

codecov bot commented Nov 28, 2021 •
edited

Codecov Report

Merging #10285 (a4bcb31) into master (f7bbd17) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10285   +/-   ##
=======================================
  Coverage   85.39%   85.39%           
=======================================
  Files         339      339           
  Lines       13854    13857    +3     
=======================================
+ Hits        11830    11833    +3     
  Misses       2024     2024
Impacted Files Coverage Δ
lib/plugins/aws/package/compile/events/stream.js 98.23% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7bbd17...a4bcb31. Read the comment docs.

@fredericbarthelet fredericbarthelet marked this pull request as ready for review November 29, 2021 11:40
pgrzesik
pgrzesik suggested changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, I have only very minor suggestions 👍 Also, please see the suggestion from @medikoo in linked issue, it might impact this PR a little bit.

docs/providers/aws/events/streams.md Outdated Show resolved Hide resolved
docs/providers/aws/events/streams.md Outdated Show resolved Hide resolved
docs/providers/aws/events/streams.md Outdated Show resolved Hide resolved
@fredericbarthelet
Copy link
Contributor Author

@pgrzesik I updated property name to filterPatterns as discussed on original issue #10284. Do you have any additional comments or is it good to go :) ?

pgrzesik
pgrzesik approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great in my opinion 👍 @medikoo could you also take a look before merging?

medikoo
medikoo approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great @fredericbarthelet

Great thanks for fast action on that!

@medikoo medikoo merged commit fc00505 into serverless:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medikoo medikoo medikoo approved these changes

@pgrzesik pgrzesik pgrzesik approved these changes

Assignees
No one assigned
Labels
cat/aws-event-stream enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fredericbarthelet @medikoo @pgrzesik