Strip null values from CloudFormation template resource properties #10304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resource properties
1 task
Codecov Report
@@ Coverage Diff @@
## master #10304 +/- ##
==========================================
+ Coverage 85.40% 85.42% +0.01%
==========================================
Files 339 339
Lines 13877 13910 +33
==========================================
+ Hits 11852 11882 +30
- Misses 2025 2028 +3
Continue to review full report at Codecov.
|
medikoo
reviewed
Dec 2, 2021
There was a problem hiding this comment.
@GurmeharS that looks great ! I've just propose one minor simplification, and it's good to go
| Object.entries(obj).forEach(([propName, propVal]) => { | ||
| if (propVal === null) { | ||
| delete obj[propName]; | ||
| } else if (propVal && typeof propVal === 'object') { |
There was a problem hiding this comment.
We can simplify to if (typeof === 'object')
There was a problem hiding this comment.
Good catch! Pushed out an update 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
stripNullPropsFromTemplateResourcesstripped null from top-level resource properties in the compiled CFN template.This PR:
Closes: #10279