Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor lib/plugins/aws/utils with Async #10309

Merged
merged 2 commits into from Dec 6, 2021

Conversation

mdanyalkhan
Copy link
Contributor

@mdanyalkhan mdanyalkhan commented Dec 5, 2021

Addresses: #{8368}
Configures all promise-related functions as async functions.

@mdanyalkhan mdanyalkhan changed the title Async lib/plugins/aws/utils Refactor lib/plugins/aws/utils with Async Dec 5, 2021
@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #10309 (ca49ff5) into master (9faf37a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10309   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files         339      339           
  Lines       13919    13919           
=======================================
  Hits        11891    11891           
  Misses       2028     2028           
Impacted Files Coverage Δ
lib/plugins/aws/utils/resolveCfImportValue.js 62.50% <ø> (ø)
lib/plugins/aws/utils/resolveCfRefValue.js 66.66% <ø> (ø)
lib/plugins/aws/utils/credentials.js 90.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9faf37a...ca49ff5. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mdanyalkhan !

@medikoo medikoo merged commit 4d4f863 into serverless:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants