ssm: Adding noDecrypt param support to SSM #10314 #10315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
medikoo
suggested changes
Dec 7, 2021
There was a problem hiding this comment.
@omerinvia great thanks for that PR. It looks very good, I have just one suggestion towards param resolution
lib/configuration/variables/sources/instance-dependent/get-ssm.js
Outdated
Show resolved
Hide resolved
medikoo
reviewed
Dec 7, 2021
There was a problem hiding this comment.
@omerinvia looks very good! I've just proposed as slight improvement to docs
medikoo
reviewed
Dec 7, 2021
Comment on lines
343
to
345
| #### Disable automatically `SecureString` decryption | ||
|
|
||
| as mentioned above, by default , `SecureString` type parameters are automatically decrypted. |
medikoo
reviewed
Dec 7, 2021
| @@ -340,6 +340,10 @@ New variable resolver, ensures that automatically other types as `SecureString` | |||
|
|
|||
| All `SecureString` type parameters are automatically decrypted, and automatically parsed if they export stringified JSON content (Note: you can turn off parsing by passing `raw` instruction into variable as: `${ssm(raw):/path/to/secureparam}`, if you need to also pass custom region, put it first as: `${ssm(eu-west-1, raw):/path/to/secureparam}`) | |||
|
|
|||
| #### Disable automatically `SecureString` decryption | |||
Codecov Report
@@ Coverage Diff @@
## master #10315 +/- ##
=======================================
Coverage 85.43% 85.43%
=======================================
Files 339 340 +1
Lines 13923 13939 +16
=======================================
+ Hits 11895 11909 +14
- Misses 2028 2030 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/serverless/serverless/issues/10314