Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws apiGateway): restApiRootResourceId is required when restApId is configured #10371

Merged
merged 2 commits into from Dec 15, 2021
Merged

fix(aws apiGateway): restApiRootResourceId is required when restApId is configured #10371

merged 2 commits into from Dec 15, 2021

Conversation

sdas13
Copy link
Contributor

@sdas13 sdas13 commented Dec 15, 2021

Closes: #8515

@codecov
Copy link

codecov bot commented Dec 15, 2021 •
edited

Codecov Report

Merging #10371 (84affd1) into master (dd033e8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10371   +/-   ##
=======================================
  Coverage   85.37%   85.38%           
=======================================
  Files         340      340           
  Lines       14001    14004    +3     
=======================================
+ Hits        11954    11957    +3     
  Misses       2047     2047
Impacted Files Coverage Δ
.../package/compile/events/apiGateway/lib/validate.js 96.41% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd033e8...84affd1. Read the comment docs.

@sdas13 sdas13 marked this pull request as ready for review December 15, 2021 16:05
medikoo
medikoo approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdas13 looks great! Thank you

@medikoo medikoo merged commit 2c0a962 into serverless:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medikoo medikoo medikoo approved these changes

Assignees
No one assigned
Labels
bug cat/aws-event-api-gateway cat/dx
Projects
None yet
Milestone
No milestone
3 participants
@sdas13 @medikoo @sdas-ntnx