Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Templates): Update aws-lambda-java-log4j2 #10383

Merged
merged 4 commits into from Dec 27, 2021

Conversation

MarinaMeza
Copy link
Contributor

Updated aws-lambda-java-log4j2 to 1.4.0 to address log4j vulnerability

Issue 10370

Addresses: #10370

Updated aws-lambda-java-log4j2 to 1.4.0 to address log4j vulnerability
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #10383 (cbf7616) into master (2782ed4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10383   +/-   ##
=======================================
  Coverage   85.37%   85.37%           
=======================================
  Files         340      340           
  Lines       14005    14005           
=======================================
  Hits        11957    11957           
  Misses       2048     2048           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2782ed4...cbf7616. Read the comment docs.

@pgrzesik
Copy link
Contributor

Thanks a lot @MarinaMeza 🙇 I've run a quick grep over the repo and it seems like there are some additional templates that use this package that could also use an upgrade:

  • aws-scala-sbt
  • aws-kotlin-jvm-gradle-kts
  • aws-kotlin-jvm-maven
  • aws-java-maven
  • aws-java-gradle

Would you be interested in upgrading them too? It would be much appreciated to cover all of them as a single commit with an upgrade.

@MarinaMeza
Copy link
Contributor Author

@pgrzesik Yes, no problem! I'll upgrade those too

@anwari666
Copy link

Hi @MarinaMeza, thanks for updating those.

I am having the same issue at my company and saw that this file

has indirect reference to log4j.

I'm not sure how it will impact the repo, but if it's a simple update then perhaps it can be updated within this commit as well?
Thanks!

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MarinaMeza, thanks a lot for your PR, I think it needs to be rebased and updated a bit and we're good to go, please see my comments 🙇

@MarinaMeza
Copy link
Contributor Author

I've updated all references to aws-lambda-java-log4j2.
I left aws-lambda-java-log4j as it was since i could not find a newer version

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MarinaMeza, it looks great, but there seem to be a conflict - could you rebase your branch on top of current master branch?

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MarinaMeza 🙇

@pgrzesik pgrzesik changed the title Update aws log4j2 fix(Templates): Update aws-lambda-java-log4j2 Dec 27, 2021
@pgrzesik pgrzesik merged commit 786f5e4 into serverless:master Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants