Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AWS Deploy): Check for VPC config change in deploy function #10409

Merged
merged 1 commit into from Dec 22, 2021

Conversation

pgrzesik
Copy link
Contributor

Ensure that ordering does not matter when comparing VPC-related values.

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #10409 (42dd4e3) into master (2782ed4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10409   +/-   ##
=======================================
  Coverage   85.37%   85.37%           
=======================================
  Files         340      340           
  Lines       14005    14005           
=======================================
  Hits        11957    11957           
  Misses       2048     2048           
Impacted Files Coverage Δ
lib/plugins/aws/deployFunction.js 96.86% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2782ed4...42dd4e3. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pgrzesik pgrzesik merged commit 0190d0d into master Dec 22, 2021
@pgrzesik pgrzesik deleted the ensure-proper-vpc-check-in-deploy-function branch December 22, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants