Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Templates): Upgrade log4j to 2.17.1 #10430

Merged
merged 2 commits into from Jan 10, 2022
Merged

fix(Templates): Upgrade log4j to 2.17.1 #10430

merged 2 commits into from Jan 10, 2022

Conversation

GrahamCampbell
Copy link
Contributor

Yes, yet another vulnerability. 馃槶

@codecov
Copy link

codecov bot commented Dec 31, 2021

Codecov Report

Merging #10430 (379637b) into master (129c0ee) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10430   +/-   ##
=======================================
  Coverage   85.89%   85.89%           
=======================================
  Files         335      335           
  Lines       13934    13934           
=======================================
  Hits        11968    11968           
  Misses       1966     1966           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 129c0ee...379637b. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @GrahamCampbell - could you also bump the versions in aws-kotlin-jvm-gradle example so we have everything covered in this PR? I think one extra will be needed for the aws-lambda-java-log4j2 library, but there's no new releases of that yet.

@GrahamCampbell
Copy link
Contributor Author

@pgrzesik Rebased, and done. :)

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @GrahamCampbell 馃檱

@pgrzesik pgrzesik changed the title Upgraded templates to log4j 2.17.1 fix(Templates): Upgrade log4j to 2.17.1 Jan 10, 2022
@pgrzesik pgrzesik merged commit 2c3ab1d into serverless:master Jan 10, 2022
@GrahamCampbell GrahamCampbell deleted the log4j branch January 10, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants