Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove querystring in @serverless/platform-client #12341

Open
1 task done
R3dLantern opened this issue Jan 30, 2024 · 4 comments
Open
1 task done

Remove querystring in @serverless/platform-client #12341

R3dLantern opened this issue Jan 30, 2024 · 4 comments

Comments

@R3dLantern
Copy link

Is there an existing issue for this?

  • I have searched existing issues, it hasn't been reported yet

Use case description

npm audit reports the usage of the deprecated querystring package within @serverless/platform-client:

querystring@0.2.1 dev
node_modules/@serverless/platform-client/node_modules/querystring
  querystring@"^0.2.1" from @serverless/platform-client@4.5.1
  node_modules/@serverless/platform-client
    @serverless/platform-client@"^4.3.2" from @serverless/dashboard-plugin@6.2.2
    node_modules/@serverless/dashboard-plugin
      @serverless/dashboard-plugin@"^6.2.2" from serverless@3.24.1
      node_modules/serverless
        dev serverless@"^3.24.1" from the root project
        peer serverless@"2 || 3" from serverless-plugin-typescript@2.1.4
        node_modules/serverless-plugin-typescript
          dev serverless-plugin-typescript@"^2.1.2" from the root project
    @serverless/platform-client@"^4.3.2" from serverless@3.24.1
    node_modules/serverless
      dev serverless@"^3.24.1" from the root project
      peer serverless@"2 || 3" from serverless-plugin-typescript@2.1.4
      node_modules/serverless-plugin-typescript
        dev serverless-plugin-typescript@"^2.1.2" from the root project

Proposed solution (optional)

The official recommendation is to replace querystring functionality with URLSearchParams. Unless there are already plans doing so, the possibility of contributing to @serverless/platform-client would create potential pull requests addressing the matter.

@dev-chester
Copy link

i wonder if it is done? can you redirect me to the commit related to this?

@R3dLantern
Copy link
Author

As far as I can see no steps have been taken yet.
@serverless/platform-client is not a public repository and its code is currently only visible in the NPM registry.

@ktwbc
Copy link

ktwbc commented Feb 28, 2024

devDependencies:
serverless 3.38.0
└─┬ aws-sdk 2.1568.0
  ├── querystring 0.2.0
  └─┬ url 0.10.3
    └── querystring 0.2.0

@R3dLantern
Copy link
Author

@ktwbc I think that would be addressed in #12369, but I specifically talk about the dependency of @serverless/platform-client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants