Exit status for deploy

[sebastianarena]

This is a Bug Report

Description

• What went wrong?
  Run serverless deploy and failed for reasons not important to this bug report
  The exit code in BASH for the failure was still 0, like nothing happened

• What did you expect should have happened?
  The exit code of anything you run throw the serverless command should be not 0 in case of an error

• What was the config you used?
  Doesn't matter, even a failed config should work in this case as a failed serverless deploy should throw some sort of error code, not 0

Additional Data

• Serverless Framework Version you're using:
  1.48.2 (Enterprise Plugin: 1.3.2, Platform SDK: 2.0.4)

• Operating System:
  macOS, Linux

[ahanoff]

Happened to me as well, invalid role assignment, but deploy marked as successful

[manchuck]

I can reproduce this every time a promise fails

[manchuck]

This has been present since 1.48.1. Downgrading to 1.48.0 reports the correct error code

[ndanielsen]

Agree. Coming over here to create this issue.

[jpic]

Still present in 1.49.0 (Enterprise Plugin: 1.3.5, Platform SDK: 2.1.0)

[medikoo]

I've investigated that, and found out it happens only with serverless-offline, and it's due to implied removal of unhandledRejection listeners

I've proposed PR there: dherault/serverless-offline#767

We will also improve handling of promise rejections with another PR, which could be considered as partial fix. Still the complete fix cannot be achieved reliably without merging dherault/serverless-offline#767.

[kaitlynbrown]

Thank you so much @medikoo this was driving me nuts!

[rodrigodgm]

This is still happening to me

[phil-andrews]

I can get the error to stop by setting package: individually to false. This seems in line with the JS heap running out of memory.

I think this could be due to recently adding Epsagon. Which forces you to include node_modules in the package. Though I could be wrong and not entirely understanding what is being packaged there. I'd check but I'm outta steam today, just wanted to leave a note for the next poor sap that stumbles in

My working yaml:

package:
  individually: false
  exclude:
    - ./** # Excludes everything
  include: # Include necessary dependencies for your function to work
    - "node_modules/**"
    - "epsagon_handlers/**"

plugins:
  - serverless-plugin-epsagon
  - serverless-webpack
  - serverless-dotenv-plugin