AWS_DEFAULT_PROFILE seems not supported by profile resolver

[dazza-codes]

There is no [default] in the ~/.aws/credentials or ~/.aws/config, to set and change profiles, the AWS_DEFAULT_PROFILE environment variable is used for awscli. But something in sls package is defaulting back to a default profile?

Serverless: Installing dependencies for custom CloudFormation resources...
 
  Serverless Error ---------------------------------------
 
  Missing credentials in config, if using AWS_CONFIG_FILE, set AWS_SDK_LOAD_CONFIG=1
 
  Get Support --------------------------------------------
     Docs:          docs.serverless.com
     Bugs:          github.com/serverless/serverless/issues
     Issues:        forum.serverless.com
 
  Your Environment Information ---------------------------
     Operating System:          linux
     Node Version:              10.20.1
     Framework Version:         1.68.0
     Plugin Version:            3.6.9
     SDK Version:               2.3.0
     Components Version:        2.30.4
 

[medikoo]

@dazza-codes can you clarify in more details what's exactly your setup, and what you expect to happen?

Do you have e.g. foo profile configured in ~/.aws/credentials and ~/.aws/config, and AWS_DEFAULT_PROFILE set to foo, and you see it not resolved in a Framework?

[dazza-codes]

Do you have e.g. foo profile configured in ~/.aws/credentials and ~/.aws/config, and AWS_DEFAULT_PROFILE set to foo, and you see it not resolved in a Framework?

Yes, exactly.

export AWS_DEFAULT_PROFILE=foo

##  ~/.aws/credentials
##  NO [default]
[foo]
... etc etc ..

[medikoo]

@dazza-codes is AWS_DEFAULT_PROFILE env var supported naturally by AWS SDK?

[medikoo]

Closing as we didn't receive enough details to process this further.

Also track #7605 as it might be related

[dazza-codes]

@medikoo - yes, the AWS_DEFAULT_PROFILE is sufficient for awscli to get everything required from ~/.aws/credentials

To work around the extra requirements to set a few more env-vars, I'm using a bash function to switch between profiles (there may be better options out there that I haven't found, but this seems to work OK when I have no default profile enabled and I have about 1/2 dozen different profiles in active use):

https://gist.github.com/dazza-codes/fe65f3214c7f2f189a928bee2524062e

[medikoo]

@dazza-codes thanks for further details. I believe problem lies in this line:

serverless/lib/plugins/aws/provider/awsProvider.js

Line 369 in b53f080

impl.addProfileCredentials(result, 'default');

As there we assume that default profile is default, where I believe we should respect AWS_DEFAULT_PROFILE.

PR with fix is welcome!

[marekpiotrowski]

I'd like to take this one. Seems relatively easy, change in the implementation should be small, I will focus on tests, though. Let me know. Thank you.

[medikoo]

@marekpiotrowski great to hear that! We look forward

[marekpiotrowski]

Pull request created: #8354
Thanks.