Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config schema: Define AWS "functions[]" section properties #8017

Closed
8 tasks done
medikoo opened this issue Jul 31, 2020 · 1 comment · Fixed by #8222 or #8385
Closed
8 tasks done

Config schema: Define AWS "functions[]" section properties #8017

medikoo opened this issue Jul 31, 2020 · 1 comment · Fixed by #8222 or #8385

Comments

@medikoo
Copy link
Contributor

medikoo commented Jul 31, 2020

Use case description

It'll be nice to have functions[] section fully validated for AWS provider case.

Proposed solution

  1. Define schema for following provider level properties (that's part of Config schema: Define AWS "provider" properties #8022)
  • environment
  • memorySize
  • role
  • runtime
  • timeout
  • tracing.lambda
  • versionFunctions
  • vpc
  1. Define schema for all properties (apart of events) at functions[] level

Note: Each event is covered with dedicated issue, and is not in scope here.

Configuration should be done directly in: lib/plugins/aws/provider/awsProvider.js:

function: {
// TODO: Complete schema, see https://github.com/serverless/serverless/issues/8017
properties: { handler: { type: 'string' } },

@medikoo
Copy link
Contributor Author

medikoo commented Oct 1, 2020

Reopenning, as apparently we still miss definitions for destinations, maximumEventAge and maximumRetryAttempts at functions[] level.

Also after adding those, we need to ensure that relaxation as configured here:

this.schema.properties.functions.patternProperties[
FUNCTION_NAME_PATTERN
].additionalProperties = true;
)
no longer applies to functions[] properties, when we're in context of AWS provider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant