Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config schema: Define AWS "alb" function event properties #8020

Closed
1 task
medikoo opened this issue Jul 31, 2020 · 0 comments · Fixed by #8291
Closed
1 task

Config schema: Define AWS "alb" function event properties #8020

medikoo opened this issue Jul 31, 2020 · 0 comments · Fixed by #8291

Comments

@medikoo
Copy link
Contributor

medikoo commented Jul 31, 2020

Use case description

It'll be nice to have alb event fully covered by schema validation

Proposed solution

  1. Define schema for following properties at provider level (that's part of Config schema: Define AWS "provider" properties #8022)
  • alb

Should be done directly in: lib/plugins/aws/provider/awsProvider.js:

// TODO: Complete schema, see https://github.com/serverless/serverless/issues/8016
serverless.configSchemaHandler.defineProvider('aws', {

  1. Define schema of all alb event properties

Should be done directly in: lib/plugins/aws/package/compile/events/alb/index.js:

// TODO: Complete schema, see https://github.com/serverless/serverless/issues/8020
this.serverless.configSchemaHandler.defineFunctionEvent('aws', 'alb', { type: 'object' });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant