Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default payload mode to 2.0 #8133

Merged
merged 3 commits into from Aug 27, 2020
Merged

Switch default payload mode to 2.0 #8133

merged 3 commits into from Aug 27, 2020

Conversation

andreizet
Copy link
Contributor

  • Changed default payload version to 2.0
  • Removed deprecation warning from both code & documentation

Closes: #7917

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2020

Codecov Report

Merging #8133 into v2 will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2    #8133      +/-   ##
==========================================
- Coverage   88.28%   88.28%   -0.01%     
==========================================
  Files         248      248              
  Lines        9432     9430       -2     
==========================================
- Hits         8327     8325       -2     
  Misses       1105     1105              
Impacted Files Coverage Δ
...lugins/aws/package/compile/events/httpApi/index.js 92.48% <ø> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b2c94...46dca4a. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @andreizet ! It looks great, it needs just one minor update

docs/deprecations.md Outdated Show resolved Hide resolved
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @andreizet !

@medikoo medikoo merged commit 4ad9c5a into serverless:v2 Aug 27, 2020
medikoo pushed a commit that referenced this pull request Sep 10, 2020
BREAKING CHANGE:
In AWS HTTP API events (`httpApi`) default `payload` was changed from `1.0` to `2.0`
medikoo pushed a commit that referenced this pull request Sep 10, 2020
BREAKING CHANGE:
In AWS HTTP API events (`httpApi`) default `payload` was changed from `1.0` to `2.0`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants