chore(aws): remove deprecated support for maximumEventAge & maximumRetryAttempts on destination #8138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tryAttemps on destination
Codecov Report
@@ Coverage Diff @@
## v2 #8138 +/- ##
==========================================
- Coverage 88.28% 88.27% -0.01%
==========================================
Files 248 248
Lines 9432 9424 -8
==========================================
- Hits 8327 8319 -8
Misses 1105 1105
Continue to review full report at Codecov.
|
medikoo
approved these changes
Aug 26, 2020
There was a problem hiding this comment.
Thank you @pgrzesik, it's perfect!
Answering your question, we definitely want to keep documentation for deprecations, as users relying on older version should have this information still available. You've made a good judgement by keeping it.
medikoo
pushed a commit
that referenced
this pull request
Sep 10, 2020
(PR #8138) BREAKING CHANGE Support for `maximumEventAge` and `maximumRetryAttemps` as set on `functions[].destinations` was removed. Those properties should be defined directly on `functions[]`
medikoo
pushed a commit
that referenced
this pull request
Sep 10, 2020
(PR #8138) BREAKING CHANGE Support for `maximumEventAge` and `maximumRetryAttemps` as set on `functions[].destinations` was removed. Those properties should be defined directly on `functions[]`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes support and deprecation message for
maximumEventAgeandmaximumRetryAttemptsset onfunction.destinationslevel.I've decided to leave the note in
docs/deprecations.mdas I'm not sure if the intention is to keep that historic information or clean it up and only show "current" deprecations. Please let me know if it should be removed.Closes: #8119