Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error if resources.extensions contains reference to not created resource #8141

Closed
medikoo opened this issue Aug 27, 2020 · 4 comments
Closed
Labels
breaking A breaking change bug/design Functionality design flaw deprecation Deprecation proposal (breaking with next major)
Milestone

Comments

@medikoo
Copy link
Contributor

medikoo commented Aug 27, 2020

Use case description

Currently we silently accept an extension to not existing resource. Ideally we should throw in such case

Proposed solution

1. In master branch

Configure deprecation to be shown at:

template.Resources[resourceName] = {};

Addressed with #8266

2. In v{nextMajor} branch

Should be implemented after v{nextMajor} branch is created and (1) is merged to master and v{nextMajor} branch

Replace configured deprecation (leaving its documentation entry), with thrown error

@medikoo medikoo added breaking A breaking change bug/design Functionality design flaw deprecation Deprecation proposal (breaking with next major) good first issue help wanted labels Aug 27, 2020
@pgrzesik
Copy link
Contributor

pgrzesik commented Sep 2, 2020

Hello 👋 I'm wondering, with v2 being close to be released, should that deprecation be introduced for v2 or to current master? I feel like it might be a short period of time for people to actually see the deprecation before it starts breaking for them in new version. What is your opinion on that?

@medikoo
Copy link
Contributor Author

medikoo commented Sep 2, 2020

@pgrzesik thanks for asking. I would work against master. If in a meantime v2 will get released then it'll automatically will be merged to master so automatically this PR will catch up. If on other hand we merge it to master before releasing v2, then we will have to implement (2) step in v2 before releasing it (and imo that's fine!)

@medikoo
Copy link
Contributor Author

medikoo commented Sep 2, 2020

Still, it's definitely not blocking for v2, otherwise it'll be marked with v2 milestone

@medikoo medikoo removed the deprecation Deprecation proposal (breaking with next major) label Feb 26, 2021
@medikoo medikoo added the deprecation Deprecation proposal (breaking with next major) label Jun 7, 2021
@medikoo medikoo added this to the v3 milestone Jun 18, 2021
@medikoo
Copy link
Contributor Author

medikoo commented Oct 22, 2021

Addressed with #10063

@medikoo medikoo closed this as completed Oct 22, 2021
@medikoo medikoo modified the milestones: v3, v3-ready Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A breaking change bug/design Functionality design flaw deprecation Deprecation proposal (breaking with next major)
Projects
None yet
Development

No branches or pull requests

2 participants