Remove support for allowUnauthenticated
#8160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v2 #8160 +/- ##
==========================================
+ Coverage 88.17% 88.20% +0.03%
==========================================
Files 248 248
Lines 9434 9405 -29
==========================================
- Hits 8318 8296 -22
+ Misses 1116 1109 -7
Continue to review full report at Codecov.
|
medikoo
suggested changes
Sep 1, 2020
There was a problem hiding this comment.
@morgan-sam In general it looks great. Code-wise I have just one remark towards documentation update.
Still all v2 proposals should be based against v2 branch, can you rebase your branch against it (I've already updated PR to show changes against this branch) ?
Thank you!
docs/deprecations.md
Outdated
| @@ -32,7 +32,7 @@ Please upgrade to use at least Node.js v10 (It's recommended to use LTS version, | |||
|
|
|||
| ## AWS ALB `allowUnauthenticated` | |||
|
|
|||
| Please use `onUnauthenticatedRequest` instead. `allowUnauthenticated` will be removed with v2.0.0 | |||
| Please use `onUnauthenticatedRequest` instead. `allowUnauthenticated` has been deprecated | |||
There was a problem hiding this comment.
Let's not update deprecation notes.
medikoo
changed the title
allowUnauthenticated
medikoo
approved these changes
Sep 1, 2020
medikoo
pushed a commit
that referenced
this pull request
Sep 10, 2020
BREAKING CHANGE: Support for `providers.alb.authorizers[].allowUnauthenticated` setting was removed. Rely on `providers.alb.authorizers[].onUnauthenticatedRequest` instead. (PR #8160)
medikoo
pushed a commit
that referenced
this pull request
Sep 10, 2020
BREAKING CHANGE: Support for `providers.alb.authorizers[].allowUnauthenticated` setting was removed. Rely on `providers.alb.authorizers[].onUnauthenticatedRequest` instead. (PR #8160)
medikoo
pushed a commit
that referenced
this pull request
Sep 10, 2020
BREAKING CHANGE: Support for `providers.alb.authorizers[].allowUnauthenticated` setting was removed. Rely on `providers.alb.authorizers[].onUnauthenticatedRequest` instead. (PR #8160)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8120
Removes allowUnauthenticated and allowUnauthenticated related tests.