Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): remove slss command alias #8161

Merged
merged 1 commit into from Sep 1, 2020
Merged

feat(cli): remove slss command alias #8161

merged 1 commit into from Sep 1, 2020

Conversation

crash7
Copy link
Contributor

@crash7 crash7 commented Sep 1, 2020

Closes: #8122

@codecov-commenter
Copy link

Codecov Report

Merging #8161 into v2 will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v2    #8161   +/-   ##
=======================================
  Coverage   88.22%   88.22%           
=======================================
  Files         248      248           
  Lines        9411     9411           
=======================================
  Hits         8303     8303           
  Misses       1108     1108
Impacted Files Coverage Δ
lib/utils/tabCompletion/tabtabOptions.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b4de09...809a173. Read the comment docs.

@medikoo medikoo added breaking A breaking change cat/cli labels Sep 1, 2020
medikoo
medikoo approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thank you @crash7

@medikoo medikoo merged commit 98ae970 into serverless:v2 Sep 1, 2020
medikoo pushed a commit that referenced this pull request Sep 10, 2020
@crash7 @medikoo
feat(cli): Remove "slss", "serverless" command alias (#8161)
e293096 
BREAKING CHANGE:
`slss` alias for `serverless` CLI ommand was removed. Rely on `sls` instead
medikoo pushed a commit that referenced this pull request Sep 10, 2020
@crash7 @medikoo
feat(CLI): Remove "slss", "serverless" command alias (#8161)
0d8a7d4 
BREAKING CHANGE:
`slss` alias for `serverless` CLI ommand was removed. Rely on `sls` instead
medikoo pushed a commit that referenced this pull request Sep 10, 2020
@crash7 @medikoo
feat(CLI): Remove "slss", "serverless" command alias (#8161)
33eef9f 
BREAKING CHANGE:
`slss` alias for `serverless` CLI ommand was removed. Rely on `sls` instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medikoo medikoo medikoo approved these changes

Assignees
No one assigned
Labels
breaking A breaking change cat/cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crash7 @codecov-commenter @medikoo