Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to service local serverless installation by default #8180

Merged
merged 2 commits into from Sep 3, 2020

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Sep 3, 2020

Closes: #7910

@medikoo medikoo added breaking A breaking change cat/cli labels Sep 3, 2020
@medikoo medikoo self-assigned this Sep 3, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2020

Codecov Report

Merging #8180 into v2 will increase coverage by 0.00%.
The diff coverage is 88.88%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v2    #8180   +/-   ##
=======================================
  Coverage   88.20%   88.20%           
=======================================
  Files         247      247           
  Lines        9443     9445    +2     
=======================================
+ Hits         8329     8331    +2     
  Misses       1114     1114           
Impacted Files Coverage Δ
lib/Serverless.js 96.00% <88.88%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee5df89...2ddf2ca. Read the comment docs.

BREAKING CHANGE:
When globally installed `serverless` CLI is invoked in a context of a service, which has locally installed (in its `node_modules`) `serverless`. The locally installed CLI will be (by default) run instead of a global one.
@medikoo medikoo force-pushed the 0903-drop-local-installation-deprecation branch from 0c5f228 to 2ddf2ca Compare September 3, 2020 08:55
@medikoo medikoo merged commit 651b375 into v2 Sep 3, 2020
@medikoo medikoo deleted the 0903-drop-local-installation-deprecation branch September 3, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A breaking change cat/cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants