Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS HTTP API: Drop support for timeout setting #8184

Merged
merged 1 commit into from Sep 3, 2020

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Sep 3, 2020

BREAKING CHANGE:
timeout setting as configured directly for httpApi event, is no longer supported. Timeout value is now unconditionally resolved from function timeout setting. It's to guarantee that configured endpoint has necessary room to process function invocation

Closes: #8087

BREAKING CHANGE:
`timeout` setting as configured directly for `httpApi` event,  is no longer supported.  Timeout value is now unconditionally resolved from  function timeout setting. It's to guarantee that configured endpoint has necessary room to process function invocation
@codecov-commenter
Copy link

Codecov Report

Merging #8184 into v2 will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2    #8184      +/-   ##
==========================================
- Coverage   88.20%   88.19%   -0.01%     
==========================================
  Files         247      247              
  Lines        9443     9432      -11     
==========================================
- Hits         8329     8319      -10     
+ Misses       1114     1113       -1     
Impacted Files Coverage Δ
lib/plugins/aws/provider/awsProvider.js 93.11% <ø> (ø)
...lugins/aws/package/compile/events/httpApi/index.js 92.59% <66.66%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc134c4...e2e96ab. Read the comment docs.

@medikoo medikoo merged commit 8394149 into v2 Sep 3, 2020
@medikoo medikoo deleted the 0903-drop-http-api-timeout-support branch September 3, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants