Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Config Schema): Support Condition attribute on resources.extensions #8217

Merged

Conversation

glb
Copy link
Contributor

@glb glb commented Sep 10, 2020

Adds support for the Condition attribute in resources.extensions.

Related: #8213
Closes: #8208

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glb great thank you! That looks good, still CI failed, due to, I think, error in test setup.

@medikoo medikoo added the bug label Sep 10, 2020
@glb glb force-pushed the 8208-add-conditions-to-resource-schema branch from 30bd7ac to 57b5243 Compare September 10, 2020 14:42
@glb glb force-pushed the 8208-add-conditions-to-resource-schema branch from 57b5243 to 282f1f9 Compare September 10, 2020 14:45
@codecov-commenter
Copy link

Codecov Report

Merging #8217 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8217   +/-   ##
=======================================
  Coverage   88.16%   88.16%           
=======================================
  Files         248      248           
  Lines        9430     9430           
=======================================
  Hits         8314     8314           
  Misses       1116     1116           
Impacted Files Coverage Δ
...ns/aws/package/lib/mergeCustomProviderResources.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f5a077...282f1f9. Read the comment docs.

@glb glb requested a review from medikoo September 10, 2020 14:50
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @glb !

@medikoo medikoo merged commit 16bae33 into serverless:master Sep 10, 2020
@glb glb deleted the 8208-add-conditions-to-resource-schema branch September 10, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Condition attribute on resources
3 participants