Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base definition of properties #8222

Merged
merged 22 commits into from Sep 21, 2020

Conversation

fredericbarthelet
Copy link
Contributor

Closes: #8017
Addresses: #8016

@fredericbarthelet fredericbarthelet marked this pull request as draft September 11, 2020 11:43
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2020

Codecov Report

Merging #8222 into master will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8222      +/-   ##
==========================================
- Coverage   88.10%   88.04%   -0.06%     
==========================================
  Files         248      248              
  Lines        9384     9329      -55     
==========================================
- Hits         8268     8214      -54     
+ Misses       1116     1115       -1     
Impacted Files Coverage Δ
lib/configSchema.js 100.00% <ø> (ø)
lib/plugins/aws/provider/awsProvider.js 93.11% <ø> (ø)
lib/classes/ConfigSchemaHandler/index.js 89.52% <100.00%> (ø)
lib/plugins/aws/package/compile/functions/index.js 97.03% <100.00%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e9e6aa...3a30bbe. Read the comment docs.

@medikoo
Copy link
Contributor

medikoo commented Sep 14, 2020

@fredericbarthelet is this intentionally posted as draft pull request?

@fredericbarthelet
Copy link
Contributor Author

@medikoo yes it is intentional, I'm not quite finished yet on this one :) Should be completed by the end of the day

@fredericbarthelet fredericbarthelet force-pushed the schema-functions branch 3 times, most recently from 19a831a to daefbee Compare September 15, 2020 15:38
@fredericbarthelet fredericbarthelet marked this pull request as ready for review September 15, 2020 16:00
@fredericbarthelet
Copy link
Contributor Author

@medikoo this PR is now ready for review when you can :)

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredericbarthelet great thanks for that!

In master I've reordered definitions so alphabetical order is respected, and I see now this branch conflicts due to that. Can you rebase it against master?

@fredericbarthelet
Copy link
Contributor Author

@medikoo I sorted the properties :) Let me know what you think

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredericbarthelet that looks outstanding! Great thanks for that. Please see my remarks, and let me know what you think

lib/plugins/aws/provider/awsProvider.js Outdated Show resolved Hide resolved
lib/plugins/aws/provider/awsProvider.js Outdated Show resolved Hide resolved
lib/plugins/aws/provider/awsProvider.js Outdated Show resolved Hide resolved
lib/plugins/aws/provider/awsProvider.js Outdated Show resolved Hide resolved
lib/plugins/aws/provider/awsProvider.js Outdated Show resolved Hide resolved
lib/plugins/aws/provider/awsProvider.js Outdated Show resolved Hide resolved
lib/plugins/aws/provider/awsProvider.js Outdated Show resolved Hide resolved
lib/plugins/aws/provider/awsProvider.js Outdated Show resolved Hide resolved
lib/plugins/aws/provider/awsProvider.js Show resolved Hide resolved
lib/plugins/aws/provider/awsProvider.js Show resolved Hide resolved
@fredericbarthelet
Copy link
Contributor Author

@medikoo I took into account all of your comments. Could you have another look at my PR and let me know if something is still missing ? thanks :)

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fredericbarthelet it looks very good! We're nearly there, please see my comments

lib/plugins/aws/provider/awsProvider.js Outdated Show resolved Hide resolved
lib/plugins/aws/provider/awsProvider.js Outdated Show resolved Hide resolved
lib/plugins/aws/provider/awsProvider.js Outdated Show resolved Hide resolved
@fredericbarthelet
Copy link
Contributor Author

@medikoo updated my PR with your latest comments :)

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredericbarthelet sorry for confusion. Tests exposed that actually package.individually is supported on function level (my bad - I totally forgot it's the case).

In light of that, we need to recognize that option on function level

@fredericbarthelet
Copy link
Contributor Author

@medikoo no problem, updated it with allowed individually property at function level :)

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredericbarthelet that looks great!

I have just last few minor (totally nit picking) style suggestions, so we're noise free and consistent. Let me know

lib/configSchema.js Outdated Show resolved Hide resolved
lib/plugins/aws/provider/awsProvider.js Outdated Show resolved Hide resolved
lib/plugins/aws/provider/awsProvider.js Outdated Show resolved Hide resolved
@fredericbarthelet
Copy link
Contributor Author

@medikoo no problem, updated to match alphabetical order and removed unecessary awsKmsArnString definition

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fredericbarthelet !

@medikoo medikoo merged commit feece9a into serverless:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config schema: Define AWS "functions[]" section properties
3 participants