New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add base definition of properties #8222
Add base definition of properties #8222
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8222 +/- ##
==========================================
- Coverage 88.10% 88.04% -0.06%
==========================================
Files 248 248
Lines 9384 9329 -55
==========================================
- Hits 8268 8214 -54
+ Misses 1116 1115 -1
Continue to review full report at Codecov.
|
@fredericbarthelet is this intentionally posted as draft pull request? |
@medikoo yes it is intentional, I'm not quite finished yet on this one :) Should be completed by the end of the day |
19a831a
to
daefbee
Compare
@medikoo this PR is now ready for review when you can :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fredericbarthelet great thanks for that!
In master
I've reordered definitions so alphabetical order is respected, and I see now this branch conflicts due to that. Can you rebase it against master?
928e564
to
1397042
Compare
@medikoo I sorted the properties :) Let me know what you think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fredericbarthelet that looks outstanding! Great thanks for that. Please see my remarks, and let me know what you think
df10779
to
28bc5fa
Compare
@medikoo I took into account all of your comments. Could you have another look at my PR and let me know if something is still missing ? thanks :) |
34aef93
to
72211f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fredericbarthelet it looks very good! We're nearly there, please see my comments
72211f7
to
eafcb91
Compare
@medikoo updated my PR with your latest comments :) |
eafcb91
to
17a4da7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fredericbarthelet sorry for confusion. Tests exposed that actually package.individually
is supported on function level (my bad - I totally forgot it's the case).
In light of that, we need to recognize that option on function level
17a4da7
to
9e25629
Compare
@medikoo no problem, updated it with allowed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fredericbarthelet that looks great!
I have just last few minor (totally nit picking) style suggestions, so we're noise free and consistent. Let me know
@medikoo no problem, updated to match alphabetical order and removed unecessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @fredericbarthelet !
Closes: #8017
Addresses: #8016