aws cloudwatchEvent event schema

[thewizarodofoz]

Closes: #8026

[codecov-commenter]

Codecov Report

Merging #8230 into master will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #8230      +/-   ##
==========================================
- Coverage   88.16%   88.09%   -0.07%     
==========================================
  Files         248      248              
  Lines        9430     9376      -54     
==========================================
- Hits         8314     8260      -54     
  Misses       1116     1116              

Impacted Files	Coverage Δ
...ws/package/compile/events/cloudWatchEvent/index.js	100.00% <100.00%> (ø)
...plugins/aws/package/compile/events/stream/index.js	98.00% <0.00%> (-0.60%)	⬇️
lib/utils/getServerlessConfigFile.js	94.11% <0.00%> (ø)
lib/plugins/aws/provider/awsProvider.js	93.11% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4af57a5...5b1f3ad. Read the comment docs.

[medikoo]

Thank you @thewizarodofoz

It looks good! Please see my remarks, also let's remove corresponding inline validation

[medikoo]

In implementation we support also object type

[medikoo]

It should be inputTemplate.

Also we're relying on same configuration in case of eventBridge event. It'll be nice to have both schemas matching.

See:

serverless/lib/plugins/aws/package/compile/events/eventBridge/index.js

Lines 17 to 64 in 6961b62

	this.serverless.configSchemaHandler.defineFunctionEvent('aws', 'eventBridge', {
	type: 'object',
	properties: {
	eventBus: { type: 'string', minLength: 1 },
	schedule: { pattern: '^(?:cron|rate)\\(.+\\)$' },
	pattern: {
	type: 'object',
	properties: {
	'version': {},
	'id': {},
	'detail-type': {},
	'source': {},
	'account': {},
	'time': {},
	'region': {},
	'resources': {},
	'detail': {},
	},
	additionalProperties: false,
	},
	input: { type: 'object' },
	inputPath: { type: 'string', minLength: 1, maxLength: 256 },
	inputTransformer: {
	type: 'object',
	properties: {
	inputPathsMap: {
	type: 'object',
	additionalProperties: { type: 'string', minLength: 1 },
	},
	inputTemplate: { type: 'string', minLength: 1, maxLength: 8192 },
	},
	required: ['inputTemplate'],
	additionalProperties: false,
	},
	},
	allOf: [
	{ anyOf: [{ required: ['pattern'] }, { required: ['schedule'] }] },
	{
	oneOf: [
	{ required: [] },
	{ required: ['input'] },
	{ required: ['inputPath'] },
	{ required: ['inputTransformer'] },
	],
	},
	],
	});
	}

[medikoo]

Let's also define minLength

[medikoo]

Thank you @thewizarodofoz it looks great! I have just one concern, please see my comment

[medikoo]

I think we should also add required: [], as technically we do not require any of this options

[medikoo]

Thank you @thewizarodofoz !