Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config file resolution memoization #8231

Merged
merged 1 commit into from Sep 14, 2020

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Sep 14, 2020

Memoize by instance, memoizing by service name doesn't work when test configuration changes in same process

Addresses issue reported here: #8212 (comment)

Memoizing by service name doesn't work when test configuration changes in same process
@medikoo medikoo added the bug label Sep 14, 2020
@medikoo medikoo self-assigned this Sep 14, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #8231 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8231   +/-   ##
=======================================
  Coverage   88.16%   88.16%           
=======================================
  Files         248      248           
  Lines        9430     9430           
=======================================
  Hits         8314     8314           
  Misses       1116     1116           
Impacted Files Coverage Δ
lib/plugins/interactiveCli/initializeService.js 100.00% <100.00%> (ø)
lib/utils/getServerlessConfigFile.js 94.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4af57a5...6a343e7. Read the comment docs.

@medikoo medikoo merged commit 3177e40 into master Sep 14, 2020
@medikoo medikoo deleted the 0914-fix-config-file-resolution branch September 14, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants