alexa smart home event schema #8255
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8255 +/- ##
==========================================
+ Coverage 88.09% 88.18% +0.08%
==========================================
Files 248 250 +2
Lines 9376 9395 +19
==========================================
+ Hits 8260 8285 +25
+ Misses 1116 1110 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thank you @thewizarodofoz it looks great. I have just one proposal, so we can reuse token format in other event definition
| @@ -11,9 +11,25 @@ class AwsCompileAlexaSmartHomeEvents { | |||
| 'package:compileEvents': this.compileAlexaSmartHomeEvents.bind(this), | |||
| }; | |||
|
|
|||
| // TODO: Complete schema, see https://github.com/serverless/serverless/issues/8024 | |||
| const appIdSchema = { | |||
There was a problem hiding this comment.
Maybe it'll be good to define awsAlexaEventToken at
Especially that it looks we will need same reference in alexaSkill event
thewizarodofoz
changed the title
make it reusable for alexaSkill
There was a problem hiding this comment.
Thanks you @thewizarodofoz ! That looks very good, I've spotted just one missing
| appId: { $ref: '#/definitions/awsAlexaEventToken' }, | ||
| enabled: { type: 'boolean' }, | ||
| }, | ||
| required: ['appId'], |
There was a problem hiding this comment.
We miss additionalProperties: false
There was a problem hiding this comment.
Thank you @thewizarodofoz it looks great. I've commented on just one minor convention thing
| @@ -234,6 +234,12 @@ class AwsProvider { | |||
| UpdateReplacePolicy: { type: 'string' }, | |||
| Condition: { type: 'string' }, | |||
| }, | |||
| awsAlexaEventToken: { | |||
There was a problem hiding this comment.
Let's maintain alphabetical order
Closes: #8024