fix(Config Schema): Add enhanced object syntax for plugins #8259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8259 +/- ##
=======================================
Coverage 88.09% 88.09%
=======================================
Files 248 248
Lines 9377 9377
=======================================
Hits 8261 8261
Misses 1116 1116
Continue to review full report at Codecov.
|
medikoo
suggested changes
Sep 18, 2020
There was a problem hiding this comment.
Thank you @jimjenkins5 ! That looks very good. I've proposed few improvements, so schema is complete
| properties: { | ||
| localPath: { type: 'string' }, | ||
| modules: { type: 'array', items: { type: 'string' } }, | ||
| }, |
There was a problem hiding this comment.
Let's make modules required, also let's add additionalProperties: false, so eventual typos are picked and not ignored.
There was a problem hiding this comment.
I made these 2 changes. Thanks!
jimjenkins5
force-pushed
the
plugins-object-schema
branch
from
9a5a829
to
9fa75b7
Compare
medikoo
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8206