Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws): add support for cf functions for fileSystemConfig #8265

Conversation

pgrzesik
Copy link
Contributor

Allow to use CF functions to define arn for fileSystemConfig. Ref is not supported because it does not return ARN for EFS Access Point. Reference doc: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-efs-accesspoint.html

Closes: #8189

@codecov-commenter
Copy link

Codecov Report

Merging #8265 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8265   +/-   ##
=======================================
  Coverage   88.09%   88.09%           
=======================================
  Files         248      248           
  Lines        9377     9377           
=======================================
  Hits         8261     8261           
  Misses       1116     1116           
Impacted Files Coverage Δ
lib/plugins/aws/provider/awsProvider.js 93.11% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d5fe7...5299908. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pgrzesik !

@BrentFarese
Copy link

Does this work for serverless.ts files? We are doing the following and it fails:

fileSystemConfig: {
        arn: { 'Fn::GetAtt': ['FileSystem', 'Arn'] } as any,
        localMountPath: '/mnt/tmp',
      },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EFS throws a warning when it shouldn't (I think)
4 participants