Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aws): add deprecation for extending nonexistent resources #8266

Conversation

pgrzesik
Copy link
Contributor

Add deprecation for extending nonexistent resources in resources.extensions.

Addresses: #8141

@codecov-commenter
Copy link

Codecov Report

Merging #8266 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8266   +/-   ##
=======================================
  Coverage   88.09%   88.09%           
=======================================
  Files         248      248           
  Lines        9377     9378    +1     
=======================================
+ Hits         8261     8262    +1     
  Misses       1116     1116           
Impacted Files Coverage Δ
...ns/aws/package/lib/mergeCustomProviderResources.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d5fe7...f8f9985. Read the comment docs.

@medikoo medikoo added bug/design Functionality design flaw deprecation Deprecation proposal (breaking with next major) labels Sep 18, 2020
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pgrzesik, that looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/design Functionality design flaw deprecation Deprecation proposal (breaking with next major)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants