Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sns event redrive policy's deadlettersqs's sqs policy error #8268

Merged
merged 1 commit into from Sep 21, 2020
Merged

fix sns event redrive policy's deadlettersqs's sqs policy error #8268

merged 1 commit into from Sep 21, 2020

Conversation

5up3r20e
Copy link
Contributor

@5up3r20e 5up3r20e commented Sep 19, 2020 •
edited

Closes: #8267

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2020 •
edited

Codecov Report

Merging #8268 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8268   +/-   ##
=======================================
  Coverage   88.08%   88.08%           
=======================================
  Files         248      248           
  Lines        9370     9370           
=======================================
  Hits         8254     8254           
  Misses       1116     1116
Impacted Files Coverage Δ
...ib/plugins/aws/package/compile/events/sns/index.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ca63c...e531591. Read the comment docs.

@5up3r20e 5up3r20e mentioned this pull request Sep 19, 2020
Closed
medikoo
medikoo approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @5up3r20e !

@medikoo medikoo merged commit 3e9e6aa into serverless:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medikoo medikoo medikoo approved these changes

Assignees
No one assigned
Labels
bug cat/aws-event-sns
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

redrivePolicy with deadLetterTargetArn for SNS events failed to create AWS::SQS::QueuePolicy
3 participants
@5up3r20e @codecov-commenter @medikoo