Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Schema: Treat null or undefined as lack of value #8272

Merged
merged 2 commits into from Sep 21, 2020

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Sep 21, 2020

Issue was exposed by CI fail: https://github.com/serverless/serverless/runs/1134654637

(in test we reset websocketApiId with a null value:

apiGateway: { websocketApiId: null },
which seems as totally valid approach)

Workaround to: ajv-validator/ajv#1287

@codecov-commenter
Copy link

Codecov Report

Merging #8272 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8272      +/-   ##
==========================================
+ Coverage   88.08%   88.10%   +0.01%     
==========================================
  Files         248      248              
  Lines        9370     9384      +14     
==========================================
+ Hits         8254     8268      +14     
  Misses       1116     1116              
Impacted Files Coverage Δ
lib/classes/ConfigSchemaHandler/index.js 89.52% <100.00%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ca63c...074dd7f. Read the comment docs.

@medikoo medikoo merged commit e5e42ba into master Sep 21, 2020
@medikoo medikoo deleted the 0921-allow-null-in-config branch September 21, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants