New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate awsKmsKeyArn for provider and functoin kmsKeyArn #8277
Deprecate awsKmsKeyArn for provider and functoin kmsKeyArn #8277
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8277 +/- ##
==========================================
+ Coverage 88.02% 88.10% +0.07%
==========================================
Files 248 250 +2
Lines 9312 9374 +62
==========================================
+ Hits 8197 8259 +62
Misses 1115 1115
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @fredericbarthelet, that looks very good! I've picked just on a few minor, mostly style related things
@medikoo I updated my PR with your comments. Let me know what you think :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @fredericbarthelet, looks great. Sorry, spotted one more issue related to deprecation codes. Let me know
@medikoo updated accordingly :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @fredericbarthelet ! It all looks great, just version number is not right in deprecation doc :)
0e98202
to
5aba3dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @fredericbarthelet !
Closes: #8261