Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate awsKmsKeyArn for provider and functoin kmsKeyArn #8277

Merged

Conversation

fredericbarthelet
Copy link
Contributor

@fredericbarthelet fredericbarthelet commented Sep 23, 2020

Closes: #8261

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2020

Codecov Report

Merging #8277 into master will increase coverage by 0.07%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8277      +/-   ##
==========================================
+ Coverage   88.02%   88.10%   +0.07%     
==========================================
  Files         248      250       +2     
  Lines        9312     9374      +62     
==========================================
+ Hits         8197     8259      +62     
  Misses       1115     1115              
Impacted Files Coverage Δ
lib/configSchema.js 100.00% <ø> (ø)
lib/plugins/aws/provider/awsProvider.js 93.11% <ø> (ø)
lib/plugins/aws/package/compile/functions/index.js 96.32% <85.71%> (-0.71%) ⬇️
lib/plugins/aws/info/display.js 81.92% <0.00%> (-0.22%) ⬇️
lib/utils/analytics/generatePayload.js 96.00% <0.00%> (-0.16%) ⬇️
lib/plugins/print/print.js 100.00% <0.00%> (ø)
lib/plugins/aws/package/compile/events/s3/index.js 100.00% <0.00%> (ø)
...lugins/aws/package/compile/events/httpApi/index.js 92.59% <0.00%> (ø)
.../aws/package/compile/events/apiGateway/lib/cors.js 100.00% <0.00%> (ø)
...kage/compile/events/apiGateway/lib/method/index.js 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8943693...5aba3dc. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fredericbarthelet, that looks very good! I've picked just on a few minor, mostly style related things

lib/plugins/aws/package/compile/functions/index.js Outdated Show resolved Hide resolved
lib/plugins/aws/package/compile/functions/index.js Outdated Show resolved Hide resolved
lib/plugins/aws/package/compile/functions/index.js Outdated Show resolved Hide resolved
lib/plugins/aws/package/compile/functions/index.js Outdated Show resolved Hide resolved
lib/plugins/aws/package/compile/functions/index.js Outdated Show resolved Hide resolved
lib/configSchema.js Outdated Show resolved Hide resolved
@medikoo medikoo added deprecation Deprecation proposal (breaking with next major) refactor cat/lambda labels Sep 23, 2020
@fredericbarthelet
Copy link
Contributor Author

@medikoo I updated my PR with your comments. Let me know what you think :)

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fredericbarthelet, looks great. Sorry, spotted one more issue related to deprecation codes. Let me know

lib/plugins/aws/package/compile/functions/index.js Outdated Show resolved Hide resolved
@fredericbarthelet
Copy link
Contributor Author

@medikoo updated accordingly :)

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fredericbarthelet ! It all looks great, just version number is not right in deprecation doc :)

docs/deprecations.md Outdated Show resolved Hide resolved
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fredericbarthelet !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/lambda deprecation Deprecation proposal (breaking with next major) refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate service.awsKmsKeyArn in favor of provider.kmsKeyArn
3 participants