Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace _.forEach with Object.entries().forEach #8280

Merged
merged 1 commit into from Sep 24, 2020

Conversation

pgrzesik
Copy link
Contributor

@pgrzesik pgrzesik commented Sep 23, 2020

Replace _.forEach with Object.entries().forEach + one missed toPairs usage to reduce dependency on lodash.

Additional note: Unless I'm missing something, there are no instances of _.each left as well.

Addresses: #7747

@codecov-commenter
Copy link

Codecov Report

Merging #8280 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8280      +/-   ##
==========================================
+ Coverage   88.02%   88.03%   +0.01%     
==========================================
  Files         248      248              
  Lines        9312     9321       +9     
==========================================
+ Hits         8197     8206       +9     
  Misses       1115     1115              
Impacted Files Coverage Δ
lib/classes/CLI.js 93.36% <100.00%> (+0.03%) ⬆️
lib/classes/PluginManager.js 96.53% <100.00%> (+0.06%) ⬆️
lib/classes/Service.js 85.48% <100.00%> (ø)
lib/plugins/aws/info/display.js 81.92% <100.00%> (-0.22%) ⬇️
lib/plugins/aws/lib/normalizeFiles.js 100.00% <100.00%> (ø)
...ins/aws/package/compile/events/alb/lib/validate.js 97.82% <100.00%> (ø)
.../aws/package/compile/events/apiGateway/lib/cors.js 100.00% <100.00%> (ø)
...kage/compile/events/apiGateway/lib/method/index.js 100.00% <100.00%> (ø)
...ompile/events/apiGateway/lib/method/integration.js 98.33% <100.00%> (ø)
.../compile/events/apiGateway/lib/method/responses.js 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b867df1...4b2085a. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pgrzesik !

Additional note: Unless I'm missing something, there are no instances of _.each left as well.

Yes it appears, those were renamed to _.forEach with #7748 I'll update the doc

@medikoo medikoo merged commit 76e02cc into serverless:master Sep 24, 2020
@medikoo medikoo mentioned this pull request Sep 24, 2020
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants