Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace _.forOwn with Object.entries().forEach #8284

Merged
merged 1 commit into from Sep 24, 2020

Conversation

pgrzesik
Copy link
Contributor

Replace _.forOwn with Object.entries().forEach to reduce dependency on lodash.

Addresses: #7747

@codecov-commenter
Copy link

Codecov Report

Merging #8284 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8284   +/-   ##
=======================================
  Coverage   88.18%   88.18%           
=======================================
  Files         250      250           
  Lines        9395     9398    +3     
=======================================
+ Hits         8285     8288    +3     
  Misses       1110     1110           
Impacted Files Coverage Δ
lib/classes/PluginManager.js 96.56% <100.00%> (+0.02%) ⬆️
lib/plugins/aws/utils/findReferences.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd5099e...946460e. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pgrzesik !

@medikoo medikoo assigned medikoo and unassigned medikoo Sep 24, 2020
@medikoo medikoo merged commit 56c7e44 into serverless:master Sep 24, 2020
@medikoo medikoo mentioned this pull request Jan 2, 2021
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants