feat(aws): add schema for alexaSkill
#8290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8290 +/- ##
==========================================
- Coverage 88.18% 88.16% -0.02%
==========================================
Files 250 250
Lines 9398 9391 -7
==========================================
- Hits 8288 8280 -8
- Misses 1110 1111 +1
Continue to review full report at Codecov.
|
medikoo
suggested changes
Sep 25, 2020
| ].join(''); | ||
| throw new this.serverless.classes.Error(errorMessage); | ||
| } | ||
| } else if (typeof event.alexaSkill === 'object') { |
There was a problem hiding this comment.
As it's a last acceptable form, we may simplify this to } else { (it'll be nice also because typeof x === 'object' feels quirky (e.g. null passes such condition))
There was a problem hiding this comment.
good call, changed 👍
medikoo
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds schema definition for
alexaSkillevent.In addition, it also adds deprecation for defining
alexaSkillwith just analexaSkillstring. That configuration is not covered by schema as it would require a rewrite of current utility for defining event schemas. Related discussion in corresponding issue.Closes: #8023