New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aws alb schema #8291
Aws alb schema #8291
Conversation
# Conflicts: # lib/plugins/aws/package/compile/events/alb/lib/validate.js # lib/plugins/aws/provider/awsProvider.js
Codecov Report
@@ Coverage Diff @@
## master #8291 +/- ##
==========================================
- Coverage 88.16% 88.12% -0.05%
==========================================
Files 250 250
Lines 9391 9365 -26
==========================================
- Hits 8280 8253 -27
- Misses 1111 1112 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, that looks great @thewizarodofoz ! I've spotted just some minor shortcomings, please see my comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @thewizarodofoz for update! Still, I see some comments not addressed/answered, have you pushed all the commits?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @thewizarodofoz, still as I see CI tests fail because regex is not right for httpCode
(It has literal d
instead of \d
which defines digit - in a string we need to input as \\d
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thewizarodofoz looks great! I've just spotted two suggestions not answered/addressed. See my comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @thewizarodofoz !
Closes: #8020
Notes:
listenerArn.match(ALB_LISTENER_PATTERN)
invalidate.js
because it's used as a parser. Feels weird importing it inawsProvider
for validating but couldn't think of a better wayconditions.header.name
- I didn't specify the pattern, seems like an overkillhealthCheck.mather.httpCode
- I didn't specify the pattern, found it very hard to do