Deprecate numbers at layers[].allowedAccounts[]

[medikoo]

Currently we accept and eventually coerce a number at account value:

serverless/lib/plugins/aws/package/compile/layers/index.js

Lines 77 to 79 in 8c4d972

	if (typeof account === 'number' && !isNaN(account)) {
	parsedAccount = `${account}`;
	}

It's uncommon and doesn't follow general project conventions where we do not introduce such corecions.

It'll be great to clean this up, so first deprecate number form, and with next major remove support for it.

[arjbholu]

Hi @medikoo

I had like to work on this issue if that's okay.

Correct me if I am wrong. Following is what I need to do:

1. I need to first add an entry to deprecate file.
2. Then add this.serverless._logDeprecation("code", "message") to the part you mentioned in the comment.

Apologies if there is any mistake. Please bear with me as this is my first time 😄

Thanks,
Arjav

[medikoo]

@arjbholu great thanks for jumping in! Still today we've merged improvements that make this obsolete (sorry forgot to close it on time 🤦 ).

Through #8319 and #8299 users can input numbers and it'll be automatically coerced to string by validation engine (so in processing logic we can be sure we deal with strings).

Closing this now, to avoid further confusion