Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AJV): Add Rest api logs definition #8309

Merged
merged 4 commits into from Sep 30, 2020

Conversation

fredericbarthelet
Copy link
Contributor

Addresses: #8018

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears tests relied on apiGatewayValidLogLevels (see CI fail). If its' indeed needed over there, I would just hardcode it to test file

@fredericbarthelet
Copy link
Contributor Author

It appears tests relied on apiGatewayValidLogLevels (see CI fail). If its' indeed needed over there, I would just hardcode it to test file

Hardcoded it for the tests that needs it.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fredericbarthelet it looks great. I have just one minor improvement suggestion. Let me know

lib/plugins/aws/provider/awsProvider.js Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #8309 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8309      +/-   ##
==========================================
- Coverage   88.09%   88.08%   -0.01%     
==========================================
  Files         250      250              
  Lines        9371     9368       -3     
==========================================
- Hits         8255     8252       -3     
  Misses       1116     1116              
Impacted Files Coverage Δ
.../compile/events/apiGateway/lib/hack/updateStage.js 95.06% <ø> (-0.09%) ⬇️
lib/plugins/aws/provider/awsProvider.js 93.21% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8293cc4...173294d. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fredericbarthelet !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants