Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNS displayName as optional property when used with topicName #8323

Merged
merged 2 commits into from Oct 1, 2020

Conversation

fredericbarthelet
Copy link
Contributor

Closes: #8294

@codecov-commenter
Copy link

Codecov Report

Merging #8323 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8323   +/-   ##
=======================================
  Coverage   88.02%   88.02%           
=======================================
  Files         249      249           
  Lines        9308     9309    +1     
=======================================
+ Hits         8193     8194    +1     
  Misses       1115     1115           
Impacted Files Coverage Δ
...ib/plugins/aws/package/compile/events/sns/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ff964...6417eef. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fredericbarthelet !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNS filter policy in functions logs wrong warning
3 participants