Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables: Fix support for "${self:}" #8343

Merged
merged 3 commits into from Oct 5, 2020
Merged

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Oct 5, 2020

It was not working for many commands, not long after introduction with #3208 (published with v1.9.0) - due to not proper handling of circular references (fixed in this PR)

Internal recognition for some commands was additionally wiped out with #8279 (published with v2.3.0) - due to fine tuning of variables regex (fixed in this PR)

This brings it back, although this functionality feels controversial, and we may consider to deprecate it at some point in a future.

@codecov-commenter
Copy link

Codecov Report

Merging #8343 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8343      +/-   ##
==========================================
- Coverage   88.01%   88.01%   -0.01%     
==========================================
  Files         249      249              
  Lines        9306     9305       -1     
==========================================
- Hits         8191     8190       -1     
  Misses       1115     1115              
Impacted Files Coverage Δ
lib/classes/Service.js 85.48% <ø> (ø)
lib/classes/Variables.js 99.72% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc34140...6dda12e. Read the comment docs.

@medikoo medikoo merged commit 7e4871b into master Oct 5, 2020
@medikoo medikoo deleted the 1005-fix-variables-self branch October 5, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants