Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Config Schema): Fix Fn::Join delimiter length schema #8349

Merged
merged 1 commit into from Oct 7, 2020

Conversation

glb
Copy link
Contributor

@glb glb commented Oct 6, 2020

Allows delimiter to be the empty string as documented by AWS.

Closes: #8344

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@7e4871b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8349   +/-   ##
=========================================
  Coverage          ?   88.01%           
=========================================
  Files             ?      249           
  Lines             ?     9307           
  Branches          ?        0           
=========================================
  Hits              ?     8192           
  Misses            ?     1115           
  Partials          ?        0           
Impacted Files Coverage Δ
lib/plugins/aws/provider/awsProvider.js 93.04% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4871b...a980599. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @glb !

@medikoo medikoo merged commit faa1dce into serverless:master Oct 7, 2020
@glb glb deleted the 8344-fix-fnsub-schema branch October 7, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema validation for Fn::Join flags empty delimiter
3 participants