Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider.kmsKeyArn and functions[].kmsKeyArn are not supported with single function deployment #8692

Closed
medikoo opened this issue Dec 30, 2020 · 3 comments
Closed

provider.kmsKeyArn and functions[].kmsKeyArn are not supported with single function deployment #8692

medikoo opened this issue Dec 30, 2020 · 3 comments
Assignees
@ifitzsimmons
Labels
bug cat/deployment cat/lambda good first issue help wanted

Comments

@medikoo
Copy link
Contributor

medikoo commented Dec 30, 2020

We overlooked with #8277 that sls deploy function has separate function update logic, and over there we still support just old version (service.awsKmsKeyArn and functions[].awsKmsKeyArn) of properties

(/cc @fredericbarthelet)

Proposed solution

Update function update logic to support new properties in same way as it happens with regular deployment
ifitzsimmons added a commit to ifitzsimmons/serverless that referenced this issue Dec 31, 2020
@ifitzsimmons
\serverless#8692: Add kmsKeyArn property to provider and
d38eb8b 
`function[]` objects for single function deployment
@ifitzsimmons
Copy link
Contributor

@medikoo If it's alright with you, I'd like to take a crack at this

ifitzsimmons added a commit to ifitzsimmons/serverless that referenced this issue Dec 31, 2020
@ifitzsimmons
\serverless#8692: Add kmsKeyArn property to provider and
4b91d90 
`function[]` objects for single function deployment
@ifitzsimmons ifitzsimmons mentioned this issue Dec 31, 2020
Merged
ifitzsimmons added a commit to ifitzsimmons/serverless that referenced this issue Dec 31, 2020
@ifitzsimmons
\serverless#8692: Add kmsKeyArn property to provider and
d67a0ad 
`function[]` objects for single function deployment
@medikoo
Copy link
Contributor Author

medikoo commented Dec 31, 2020

@ifitzsimmons that'll be great. Thank you!

@pgrzesik
Copy link
Contributor

It was addressed via: ifitzsimmons@d67a0ad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ifitzsimmons ifitzsimmons

Labels
bug cat/deployment cat/lambda good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@medikoo @pgrzesik @ifitzsimmons