Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Telemetry): Improve AWS stack error codes #9510

Merged
merged 2 commits into from May 24, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented May 21, 2021

  • Improve code naming consistency (so all cloudformation service errors start with AWS_CLOUD_FORMATION_
  • Recognize permission errors and report them with AWS_CLOUD_FORMATION_<action>_INSUFFICIENT_PERMISSIONS

@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #9510 (d215a85) into master (bbff029) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9510      +/-   ##
==========================================
- Coverage   86.75%   86.75%   -0.01%     
==========================================
  Files         322      322              
  Lines       12096    12099       +3     
==========================================
+ Hits        10494    10496       +2     
- Misses       1602     1603       +1     
Impacted Files Coverage Δ
lib/plugins/aws/lib/monitorStack.js 97.43% <66.66%> (-1.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbff029...d215a85. Read the comment docs.

@medikoo medikoo requested a review from pgrzesik May 21, 2021 16:01
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pgrzesik pgrzesik changed the title Telemetry: Improve AWS stack error codes refactor(Telemetry): Improve AWS stack error codes May 24, 2021
@pgrzesik pgrzesik merged commit c265905 into master May 24, 2021
@pgrzesik pgrzesik deleted the 0521-improve-error-codes-consistency branch May 24, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants