Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Templates): Add automatic source maps stacktrace to aws-nodejs-typescript #9961

Conversation

adriencaccia
Copy link
Contributor

This PR add automatic source maps in errors stacktrace.
The line import 'source-map-support/register'; will no longer be needed in a handler.

Exemple stack trace with source maps:
image

Copy link
Contributor

@fredericbarthelet fredericbarthelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement :) Thanks @adriencaccia

@medikoo medikoo self-assigned this Sep 16, 2021
@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #9961 (698ac83) into master (7828cc7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9961   +/-   ##
=======================================
  Coverage   86.17%   86.17%           
=======================================
  Files         330      330           
  Lines       13032    13032           
=======================================
  Hits        11230    11230           
  Misses       1802     1802           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7828cc7...698ac83. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @adriencaccia !

@medikoo medikoo merged commit 28d230f into serverless:master Sep 16, 2021
@adriencaccia adriencaccia deleted the aws-nodejs-typescript/automatic-sourcemap-stacktrace branch September 16, 2021 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants