Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Refactor to modern interface remaining verbose logs that affect deploy operation #9967

Merged
merged 9 commits into from Sep 17, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Sep 16, 2021

Addresses #9860

Some verbose logs are triggered via --verbose but some (mostly command agnostic, as not all commands support --verbose flag) are triggered via SLS_DEBUG=*

This PR converts all remaining those which were exposed with SLS_DEBUG=* flag. Some of those logs qualify as indeed debug logs and those were propagated to debug log level (in future to be displayed with --debug flag)

Additionally:

  • Fixed issue, where package command summary was displayed after deploy command
  • Fixed timing of final status log messages. Now they're guaranteed to be displayed at the end of command processing
  • Fix CF stack updates progress bar messaging (due to internal destructive operations triggered only in verbose mode, these messaging was different in verbose mode, and that was not expected)
  • Ensure to strip any colors with which error message may be configured (e.g. in case of Credential error, in error message link is decorated with green color)
  • Fixed improper promise handing in AWS schedule tests (regression introduced with feat(AWS Schedule): Allow multiple rate expressions in single event #9892 cc @federicojasson) which in some scenarios caused no further tests output being printed

@medikoo medikoo force-pushed the 0916-cli-redesign-improvements branch from 78dbf75 to d09e30d Compare September 16, 2021 15:03
@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #9967 (74fcd4d) into master (fa2507d) will decrease coverage by 0.03%.
The diff coverage is 83.67%.

❗ Current head 74fcd4d differs from pull request most recent head 09d3bda. Consider uploading reports for the commit 09d3bda to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9967      +/-   ##
==========================================
- Coverage   86.19%   86.16%   -0.04%     
==========================================
  Files         329      329              
  Lines       13042    13057      +15     
==========================================
+ Hits        11242    11250       +8     
- Misses       1800     1807       +7     
Impacted Files Coverage Δ
lib/plugins/aws/info/index.js 100.00% <ø> (ø)
lib/Serverless.js 69.05% <66.66%> (+0.28%) ⬆️
lib/classes/PluginManager.js 93.06% <66.66%> (-1.13%) ⬇️
lib/plugins/aws/deploy/index.js 92.42% <76.92%> (-4.01%) ⬇️
lib/classes/Service.js 86.11% <80.00%> (+0.29%) ⬆️
lib/plugins/aws/lib/monitorStack.js 93.54% <87.50%> (-1.08%) ⬇️
lib/aws/request.js 91.34% <100.00%> (+0.25%) ⬆️
lib/cli/handle-error.js 88.65% <100.00%> (+0.11%) ⬆️
lib/plugins/aws/deploy/lib/checkForChanges.js 98.61% <100.00%> (-0.01%) ⬇️
lib/plugins/aws/info/display.js 74.28% <100.00%> (-0.26%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa2507d...09d3bda. Read the comment docs.

@medikoo medikoo merged commit a8d1713 into master Sep 17, 2021
@medikoo medikoo deleted the 0916-cli-redesign-improvements branch September 17, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant