Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Generalize handling of main progress points #9976

Merged
merged 5 commits into from Sep 20, 2021
Merged

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Sep 20, 2021

Addresses #9860

To this point main progress titles were configured within internal logic, which shared some issues:

  • It was hard to deduct what exactly progress steps are configured for given command
  • Was susceptible to gaps, as plugins could inject with some before or after hooks into logic points then attributed to not right progress steps

With this change, main progress steps are configured directly on command schema by referencing lifecycle engine events which mark the start of a given step.

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #9976 (cfe2612) into master (a8d1713) will increase coverage by 0.02%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9976      +/-   ##
==========================================
+ Coverage   86.16%   86.18%   +0.02%     
==========================================
  Files         329      329              
  Lines       13057    13065       +8     
==========================================
+ Hits        11250    11260      +10     
+ Misses       1807     1805       -2     
Impacted Files Coverage Δ
lib/cli/commands-schema/aws-service.js 100.00% <ø> (ø)
lib/cli/commands-schema/service.js 100.00% <ø> (ø)
lib/plugins/aws/lib/updateStack.js 98.63% <ø> (-0.02%) ⬇️
lib/classes/PluginManager.js 93.27% <86.66%> (+0.21%) ⬆️
lib/plugins/aws/deploy/index.js 95.38% <100.00%> (+2.96%) ⬆️
lib/plugins/package/lib/packageService.js 91.86% <100.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8d1713...cfe2612. Read the comment docs.

@medikoo medikoo changed the title CLI: Generalize handling of main progress point CLI: Generalize handling of main progress points Sep 20, 2021
@medikoo medikoo merged commit 9e308bd into master Sep 20, 2021
@medikoo medikoo deleted the 0917-main-progress branch September 20, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant