Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "BucketKeyEnabled" to S3 schema #9985

Merged

Conversation

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #9985 (4d2bc95) into master (af39fc0) will not change coverage.
The diff coverage is n/a.

❗ Current head 4d2bc95 differs from pull request most recent head dc0cf8f. Consider uploading reports for the commit dc0cf8f to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9985   +/-   ##
=======================================
  Coverage   86.18%   86.18%           
=======================================
  Files         329      329           
  Lines       13070    13070           
=======================================
  Hits        11265    11265           
  Misses       1805     1805           
Impacted Files Coverage Δ
...gins/aws/package/compile/events/s3/configSchema.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af39fc0...dc0cf8f. Read the comment docs.

Copy link
Contributor

@mnapoli mnapoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let you review the technical side @medikoo but looks really simple to merge, +1 for me

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jlarmstrongiv !

@medikoo medikoo merged commit 54bb13b into serverless:master Sep 22, 2021
@jlarmstrongiv jlarmstrongiv deleted the jlarmstrongiv-patch-bucket-key branch September 22, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS S3 unrecognized property 'BucketKeyEnabled'
3 participants